Remove test-log and env_logger.
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test-log` is used with logging to set up `env_logger` for each test and was only used in the box constraints code. This code doesn't actually use logging, so this wasn't doing much.
DJMcNab
approved these changes
Apr 16, 2024
|
And if so, we'd probably want it with the tracing / tracing_subscriber approach since the code that used to log here now uses tracing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-logis used with logging to set upenv_loggerfor each test and was only used in the box constraints code. This code doesn't actually use logging, so this wasn't doing much.