Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a minimal xilem_masonry #205

Merged
merged 12 commits into from
Apr 25, 2024
Merged

Create a minimal xilem_masonry #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8d73ebf
Create a minimal xilem_masonry
DJMcNab Apr 24, 2024
ccf625f
Add a first draft of view sequences
DJMcNab Apr 24, 2024
5fd9474
Implement a flex view
DJMcNab Apr 25, 2024
7355a71
Fix clippy
DJMcNab Apr 25, 2024
ff1b30a
Update CI to 1.77
DJMcNab Apr 25, 2024
2c90b5d
Skip masonry docs in CI
DJMcNab Apr 25, 2024
a9f69a6
Clippy, again
DJMcNab Apr 25, 2024
cd00f02
Fix clippy
DJMcNab Apr 25, 2024
7e4f65b
Skip render snapshot tests
DJMcNab Apr 25, 2024
579c117
Skip testing which needs rendering on CI
DJMcNab Apr 25, 2024
d314486
Add tuple sequences
DJMcNab Apr 25, 2024
45d561b
Address review comments and clippy
DJMcNab Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ env:
# version like 1.70. Note that we only specify MAJOR.MINOR and not PATCH so that bugfixes still
# come automatically. If the version specified here is no longer the latest stable version,
# then please feel free to submit a PR that adjusts it along with the potential clippy fixes.
RUST_STABLE_VER: "1.75" # In quotes because otherwise 1.70 would be interpreted as 1.7
RUST_STABLE_VER: "1.77" # In quotes because otherwise 1.70 would be interpreted as 1.7
# We do not run the masonry snapshot tests, because those require a specific font stack
SKIP_RENDER_SNAPSHOTS: 1
# We do not run the masonry render tests, because those require Vello rendering to be working
# See https://github.com/linebender/vello/pull/439
SKIP_RENDER_TESTS: 1

# Rationale
#
Expand Down Expand Up @@ -105,4 +110,5 @@ jobs:
uses: Swatinem/rust-cache@v2

- name: cargo doc
run: cargo doc --workspace --all-features --no-deps --document-private-items -Zunstable-options -Zrustdoc-scrape-examples
# We currently skip checking masonry's docs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're probably going to need to make an issue for this

run: cargo doc --workspace --all-features --no-deps --document-private-items -Zunstable-options -Zrustdoc-scrape-examples --exclude masonry
Loading