Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update parley. #221

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

waywardmonkeys
Copy link
Contributor

This version of parley has fontique as a separate crate and has updated dependencies (as well as a removal of clap as a transitive dep).

@waywardmonkeys
Copy link
Contributor Author

Well, looks like a good thing we tried this before publishing parley!

(I haven't looked into this yet.)

cc: @dfrg

@waywardmonkeys
Copy link
Contributor Author

This is because of the update to roxmltree!

@waywardmonkeys
Copy link
Contributor Author

Once linebender/parley#43 lands, I'll give this a try again so we can update without the change to roxmltree. (I don't have a fontconfig system to experiment with.)

This version of parley has fontique as a separate crate and has
updated dependencies (as well as a removal of clap as a transitive
dep).
@waywardmonkeys
Copy link
Contributor Author

@DJMcNab This is re-running now with the parley-up-through-memmap2-update tree.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's worth testing this here, even if we can't use latest main.

@waywardmonkeys
Copy link
Contributor Author

Yes, this gets us slimmer dependencies as well as the variants improvement, so it is good. Just sad that roxmltree update broke things (but also good to know!).

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Apr 26, 2024
Merged via the queue into linebender:main with commit 571c20d Apr 26, 2024
7 checks passed
@waywardmonkeys waywardmonkeys deleted the update-parley branch April 26, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants