-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-export parley && vello #234
Conversation
Thanks for your interest! I do think we'll probably want this, however, the same logic also applies elsewhere down the stack. This leads to there being lots of paths to the same item, which leads to a poor experience when using the crates. E.g. you end up having Ideally there would be an easy way to avoid that, but we haven't worked that out yet. Suggestions welcome See also #223, where I suggest deferring a similar question until after the upcoming conference. |
I've opened a thread in the Zulip as an easier place to discuss solutions |
ok, looking forward to a better solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some discussion in Zulip, I'm relatively happy to land this, recognising that we might rework this in future.
I'm not convinced by the #[doc(inline)]
attribute; it has some pretty big disadvantages. E.g. it breaks source links on docs.rs. Cc @xStrom , as you added the attribute causing this in linebender/druid#733
Please remove the doc(inline)
attribute from at least the new items, then we can land this. Thanks!
(I think for Vello, I'd prefer to re-export a smaller subset of their API, from the root, for example)
Vello and Xilem should have a prelude for ergonomics, where these types live. |
|
@ykerit what do you mean by this comment? #234 (comment) |
In the last line I mentioned that I have completed what you suggested 😂 |
Ah, I see now - you hid that within the quote, so it was not clear to me |
I try to use masonry to implement my own application, which requires vello and parley