Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-export parley && vello #234

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

ykerit
Copy link
Contributor

@ykerit ykerit commented Apr 29, 2024

I try to use masonry to implement my own application, which requires vello and parley

@DJMcNab
Copy link
Member

DJMcNab commented Apr 29, 2024

Thanks for your interest!

I do think we'll probably want this, however, the same logic also applies elsewhere down the stack. This leads to there being lots of paths to the same item, which leads to a poor experience when using the crates.

E.g. you end up having masonry::kurbo::Point and masonry::vello::kurbo::Point and masonry::parley::kurbo::Point, and worse, you will likely end up using different paths in different imports.

Ideally there would be an easy way to avoid that, but we haven't worked that out yet. Suggestions welcome

See also #223, where I suggest deferring a similar question until after the upcoming conference.

@DJMcNab
Copy link
Member

DJMcNab commented Apr 29, 2024

I've opened a thread in the Zulip as an easier place to discuss solutions

@ykerit
Copy link
Contributor Author

ykerit commented Apr 30, 2024

ok, looking forward to a better solution

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion in Zulip, I'm relatively happy to land this, recognising that we might rework this in future.

I'm not convinced by the #[doc(inline)] attribute; it has some pretty big disadvantages. E.g. it breaks source links on docs.rs. Cc @xStrom , as you added the attribute causing this in linebender/druid#733

Please remove the doc(inline) attribute from at least the new items, then we can land this. Thanks!

(I think for Vello, I'd prefer to re-export a smaller subset of their API, from the root, for example)

@simbleau
Copy link
Member

Vello and Xilem should have a prelude for ergonomics, where these types live.

@ykerit
Copy link
Contributor Author

ykerit commented Apr 30, 2024

After some discussion in Zulip, I'm relatively happy to land this, recognising that we might rework this in future.

I'm not convinced by the #[doc(inline)] attribute; it has some pretty big disadvantages. E.g. it breaks source links on docs.rs. Cc @xStrom , as you added the attribute causing this in linebender/druid#733

Please remove the doc(inline) attribute from at least the new items, then we can land this. Thanks!

(I think for Vello, I'd prefer to re-export a smaller subset of their API, from the root, for example)
Done, Already removed

@DJMcNab
Copy link
Member

DJMcNab commented Apr 30, 2024

@ykerit what do you mean by this comment? #234 (comment)

@ykerit
Copy link
Contributor Author

ykerit commented Apr 30, 2024

In the last line I mentioned that I have completed what you suggested 😂
@DJMcNab

@DJMcNab DJMcNab added this pull request to the merge queue Apr 30, 2024
@DJMcNab
Copy link
Member

DJMcNab commented Apr 30, 2024

Ah, I see now - you hid that within the quote, so it was not clear to me

Merged via the queue into linebender:main with commit 90a5005 Apr 30, 2024
7 checks passed
@ykerit ykerit deleted the re-export-masonry branch May 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants