masonry: Disable render tests by default #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set both `ENABLE_RENDER_TESTS=1` and `ENABLE_RENDER_SNAPSHOTS=1` in your environment to run the tests.
|
My concerns with this PR:
|
DJMcNab
reviewed
May 8, 2024
| @@ -238,7 +243,7 @@ impl TestHarness { | |||
| /// Create a bitmap (an array of pixels), paint the window and return the bitmap as an 8-bits-per-channel RGB image. | |||
| pub fn render(&mut self) -> RgbaImage { | |||
| let (scene, _tree_update) = self.render_root.redraw(); | |||
| if std::env::var("SKIP_RENDER_TESTS").is_ok_and(|it| !it.is_empty()) { | |||
| if !check_env_enabled("ENABLE_RENDER_TESTS") { | |||
There was a problem hiding this comment.
So as it happens, the render tests mostly work fine
So I'd probably revert this half of the change
|
One other difference is that one part of this was reading the env variable at runtime via |
|
So, my expected updates for this PR would be.
Alternatively, we could close this pending the fixed snapshot tests (i.e. #233), but that is at least another couple of weeks away. |
|
I think we can close this now that render tests work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set both
ENABLE_RENDER_TESTS=1andENABLE_RENDER_SNAPSHOTS=1in your environment to run the tests.