Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git lfs to store Masonry screenshots #475

Closed
wants to merge 3 commits into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Aug 1, 2024

Also restores caching for Rust code in merge queues and in new PRs, which was lost when we migrated to merge queues.

Copy link
Contributor

@PoignardAzur PoignardAzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image diff previews all say "Unable to render rich display. Invalid image source." Is that normal?

Otherwise, LGTM.

@DJMcNab
Copy link
Member Author

DJMcNab commented Aug 5, 2024

Yeah. GitHub doesn't know how to handle the transition into lfs properly.

Right, I'll merge this into #233 and then land that, I think. Thanks for the approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants