Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable clippy::doc_markdown for non-masonry crates. #480

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Enable clippy::doc_markdown for non-masonry crates. #480

merged 3 commits into from
Aug 2, 2024

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@waywardmonkeys
Copy link
Contributor Author

This lets our clippy builds check clippy::doc_markdown in xilem and friends but suppresses it in masonry since otherwise it would fail.

This is a result of #449.

@waywardmonkeys
Copy link
Contributor Author

This is also a precursor to having a discussion about enabling `RUSTDOCFLAGS="-D warnings" in all of the Linebender repos.

DJMcNab
DJMcNab approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Cargo.toml Outdated Show resolved Hide resolved
masonry/src/lib.rs Outdated Show resolved Hide resolved
@waywardmonkeys waywardmonkeys added this pull request to the merge queue Aug 2, 2024
Merged via the queue into linebender:main with commit b35162b Aug 2, 2024
16 checks passed
@waywardmonkeys waywardmonkeys deleted the enable-doc-markdown-etc-but-not-in-masonry branch August 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @DJMcNab