Add --no-fail-fast to CI testing.
#738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
approved these changes
Nov 11, 2024
| @@ -269,6 +268,9 @@ jobs: | |||
| name: masonry-snapshot-tests-${{ matrix.os }} | |||
| path: masonry/src/widget/screenshots | |||
|
|
|||
| - name: cargo test --doc | |||
There was a problem hiding this comment.
Hmm. We likely do want these to produce screenshots - see #501.
There was a problem hiding this comment.
Well, it won't be a big task to move it if it makes sense with the new screenshot implementation. As for right now, it looks like we don't even have an implementation, so the details may change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time is spent on compiling, so might as well see all the tests that fail.
Also the
cargo test --docstep is moved after the screenshot failure upload to make it clearer that the doc tests don't produce any screenshots.