Default to a line height of 1.2 #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
commented
Nov 22, 2024
There was a problem hiding this comment.
This change is surprising to me.
There was a problem hiding this comment.
This moved in the opposite direction compared to the rest of the items in this PR. I wonder if this has anything to do with the alignment handling within textbox. Maybe padding only being counted once instead of both top and bottom?
There was a problem hiding this comment.
Looking at it again, it looks like the top line in all of the examples dropped, so I think this is fine.
dfrg
approved these changes
Nov 22, 2024
nicoburns
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#normal