Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a transform on the root AccessKit node #764

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Set a transform on the root AccessKit node #764

merged 2 commits into from
Nov 28, 2024

Conversation

mwcampbell
Copy link
Contributor

This is better than having to apply the scale factor to the bounding rectangles of all nodes, especially when we take externally generated AccessKit nodes, such as those generated by Parley, into account.

@mwcampbell mwcampbell mentioned this pull request Nov 28, 2024
Merged
dfrg
dfrg approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not able to properly test this but the code looks good to me and the change makes sense.

DJMcNab
DJMcNab approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better, but it seems like AccessCtx::scale_factor is now of unclear value, except for the root widget.

The equivalent code for paint is done at the render time.

masonry/src/passes/accessibility.rs Show resolved Hide resolved
DJMcNab
DJMcNab approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this new change is nicer, and can land.

@mwcampbell mwcampbell added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 3b18fc3 Nov 28, 2024
17 checks passed
@mwcampbell mwcampbell deleted the accesskit-root-transform branch November 28, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@dfrg dfrg dfrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwcampbell @dfrg @DJMcNab