Clear compose in TextArea::reset_text #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user may be composing when the `TextArea` text is programmatically changed. This change clears the compose state in order to adhere to the `PlainEditor` requirements. It is disruptive, but we already warn about disruption (and about IME in particular) in the documentation of `TextArea::reset_text`. This doesn't reset the platform's IME state, we could do, but that's potentially even more disruptive, and looks like it's a bit harder to wire up. We could also re-insert the preedit text. That'd be nicest to do if we can query `PlainEditor` for the current preedit text, which requires an API change there.
|
Ah, seems like we crossed each other. But yeah, let's land this now, as it's quite easy to cause crashes in the current state. |
|
Note for posterity: there's a separate issue in Xilem where views like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user may be composing when the
TextAreatext is programmatically changed. This change clears the compose state in order to adhere to thePlainEditorrequirements. It is disruptive, but we already warn about disruption (and about IME in particular) in the documentation ofTextArea::reset_text.This doesn't reset the platform's IME state, we could do, but that's potentially even more disruptive, and looks like it's a bit harder to wire up. We could also re-insert the preedit text. That'd be nicest to do if we can query
PlainEditorfor the current preedit text, which requires an API change there.