Skip to content

Remove screenshots from online docs export. #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025
Merged

Conversation

PoignardAzur
Copy link
Contributor

No description provided.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable solution. We should check that this doesn't stop docs building (our docs.rs check doesn't actually work for this macro, as I've discovered by building the docs locally)

#[cfg(docsrs)]
// TODO - Re-enable this once we find a way to load screenshots that doesn't go against our
// storage quotas.
#[cfg(FALSE)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-lang/rust#138632

cfg(false) should be stable in 6 weeks!

@DJMcNab
Copy link
Member

DJMcNab commented May 8, 2025

We should document this in ARCHITECTURE.md as well

@PoignardAzur PoignardAzur enabled auto-merge May 8, 2025 14:23
@PoignardAzur PoignardAzur added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit 4ebfeed May 8, 2025
18 checks passed
@PoignardAzur PoignardAzur deleted the disable_images branch May 8, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants