Correct the get_mut and get_mut_or_default for ByteMapView
#2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuDutSik
requested review from
Twey,
ma2bd,
ndr-ds,
jvff,
afck and
christos-h
ma2bd
reviewed
Jul 14, 2024
MathieuDutSik
force-pushed
the
map_view_correct
branch
from
a68f448 to
9030d5d
Compare
ma2bd
approved these changes
Jul 15, 2024
linera-views/src/map_view.rs
Outdated
| }; | ||
| Ok(match update { | ||
| None => None, | ||
| Some(update) => match update { |
There was a problem hiding this comment.
nit: Some(Update::Removed) => None etc to avoid nested matches (the compiler will re-optimize)
using Result systematically.
MathieuDutSik
force-pushed
the
map_view_correct
branch
from
f25ee92 to
6da1d10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For those two functions, the
deleted_prefixeswere not handled which is a mistake.Proposal
While being at that some other things were done:
.unwrap()were replaced by?and the use ofResult<()>or similar.get_mutand similar functions inCollectionView/ReentrantCollectionViewwas changed so that it now takes a&[u8]instead ofVec<u8>for simplicity.load_valuewas eliminated.Test Plan
A specific test that repro
Release Plan
The internal documentation of the functions was changed to reflect the new API.
Links