use CryptoHash instead of ChainAndHeight in received_log #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
approved these changes
Jul 18, 2024
|
|
||
| let certificate = node.download_certificate(certificate_hash).await?; | ||
| for hash in response.info.requested_received_log { | ||
| let certificate = node.download_certificate(hash).await?; |
There was a problem hiding this comment.
Wouldn't it be more efficient to query the local node first? Since this is based on the validator-specific tracker, wouldn't we download each certificate from every validator?
There was a problem hiding this comment.
This is the current behavior. I'll look into changing that in the next PR
There was a problem hiding this comment.
Is it? Aren't we checking that by making the local node query you are removing?
There was a problem hiding this comment.
Oh you're right! My bad. Let me maintain this behavior then.
There was a problem hiding this comment.
@afck I updated the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ChainStateViewin the local node (possibly more congested than storage) when we're downloading certificatesProposal
Use
CryptoHashinstead ofChainAndHeightinreceived_log.Possible drawbacks:
received_log.Test Plan
CI
Release Plan