-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit network actions to tracked chains (in main
)
#2393
Merged
jvff
merged 13 commits into
main
from
limit-network-actions-to-tracked-chains-in-testnet-abel
Aug 28, 2024
+144
−15
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e0ef37e
Add a `tracked_chains` field to `ChainWorkerState`
jvff ff8565c
Add a `tracked_chains` field to `WorkerState`
jvff 91dcdd0
Add a `tracked_chains` field to `Client` type
jvff df1a875
Select tracked chains when starting
jvff 27d7b20
Forward tracked chains to `WorkerState`
jvff 9ea30f6
Only create network actions for tracked chains
jvff 16fe341
Add `retry_pending_cross_chain_requests` helper
jvff 19aa4ed
Add `Client::track_chain` method
jvff 0ae1b41
Track newly created chains
jvff af3ecc9
Ensure newly assigned chain is tracked
jvff 3b6cae5
Track chains used in benchmark
jvff e9acb48
Add a TODO to merge tracked chains set
jvff ecb1f71
Track chains created during block execution
jvff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Track newly created chains
Ensure that chains that the client open are tracked.
commit 0ae1b410d1a07a4ea8b44acb526b4c629ac15193
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not even sure we always want that. E.g. the faucet probably shouldn't track all its children. Maybe it's better to default to not doing that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of what we discussed offline: for most users it makes sense to track child chains they create. For the Faucet it's not great, but not tracking them would increase the size of its outboxes, which could be less scalable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure: By "tracking" here, do you mean subscribing to notifications or just allowing a local chain state to exist?(found the answer I think)