Reorganize files #2880
Merged
Reorganize files #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deuszx
force-pushed
the
reorganize-files
branch
from
63d2504 to
9ba8855
Compare
ma2bd
reviewed
Nov 13, 2024
| signatures, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we start thinking about having unit tests in the same source files?
There was a problem hiding this comment.
Sure, do you want me to write them or move around? b/c this PR is just about moving around. I can create issues to write these unit tests.
As for the conversions above - I'm assuming that the e2e tests would catch any errors in the mappings and in the future it (the mapping) will go away entirely as we'll get rid of the Certificate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
certificate.rsstarted to grow quite large, anddata_types.rswas already huge (almost 1500 lines of code).Proposal
This PR moves code around and puts them into a common
certificatemodule. Things that were done:certificate.rsinto a modulecertificatewith separate files for different certificate types (containing respective structs, impls and conversions)certificate/hashed.rsand putHashedstruct there (with all of the accompanying code)Certificatetype (which is now an alias forGenericCertificate<ConfirmedValue>) to thecertificate/mod.rs(with a plan to remove it entirely when the time comes)CertificateValueandHashedCertificateValuetocertificate/value.rsfile.LiteCertificatetocertificate/lite.rsfile.Test Plan
None, this is just moving code around.
Release Plan
Links