Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build for examples/nextjs-swc. #2146

Closed
wants to merge 1 commit into from
Closed

Conversation

Barik85
Copy link

@Barik85 Barik85 commented Jan 7, 2025

Description

Fixed build for examples/nextjs-swc.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Jan 7, 2025 0:59am

Copy link

github-actions bot commented Jan 7, 2025

size-limit report 📦

Path Size
packages/core/dist/index.mjs 2.91 KB (0%)
packages/detect-locale/dist/index.mjs 618 B (0%)
packages/react/dist/index.mjs 1.37 KB (0%)

Comment on lines -6 to +15
turbo: {
rules: {
'*.po': {
loaders: ['@lingui/loader'],
as: '*.js'
}
}
}
}
},
webpack: (config) => {
config.module.rules.push({
test: /\.po$/,
use: {
loader: '@lingui/loader',
},
})
return config
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was explicitly changed to use Turbopack in the #2073 PR

@timofei-iatsenko
Copy link
Collaborator

timofei-iatsenko commented Jan 15, 2025

@Barik85 thanks for you contribution. I took your changes as base and prepare my pr with fixes to build process. I'm closing this one in favour of my PR. Thanks again for letting me know that something is wrong with this example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants