Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint #152

Merged
merged 9 commits into from
Apr 13, 2016
Merged

Sprint #152

merged 9 commits into from
Apr 13, 2016

Conversation

hab278
Copy link
Collaborator

@hab278 hab278 commented Mar 23, 2016

A simple cucumber story that lets an admin create a new language.

After the creation of a new language in a given group. Admin can add a description, change property value, set a new property value, and add an example. Finally the admin saves his language.

Comes with many bug fixes:

  • 15d6987 - Fixes JS issue where the create example modal wasn't popping up even after adding a new value
  • 8ef0dce - Fixes issue where the language's description wasn't being saved
  • 7043b03 - Fixes major issue which allows memberships to be used as a resource
  • cd8a677 - Fixes issue where haml was printing ruby code as literal
  • cd8a677 - Gives Admin full privileges. The issue is still at large, code attempts to get resource of a relationship, but will be fixed in next sprint...

@dej611
Copy link
Collaborator

dej611 commented Mar 29, 2016

It looks that there's some issue with some dependency. Does it work on your machine?

@hab278
Copy link
Collaborator Author

hab278 commented Mar 30, 2016

@dej611 That's strange, I hadn't changed the Gemfile. I'll rerun the tests on Travis and see what the issue is with alphabetical_paginate.

@hab278 hab278 closed this Mar 30, 2016
@hab278 hab278 reopened this Mar 30, 2016
@hab278
Copy link
Collaborator Author

hab278 commented Mar 30, 2016

@dej611 Cool, Travis is using some new platform for precise builds, comes with an older version of bundler. Travis is still failing, but this time for the same reason as master. Do you want me to apply the fix or should I pull that from origin?

@hab278
Copy link
Collaborator Author

hab278 commented Mar 30, 2016

@dej611 I might just apply the fix myself.

@dej611
Copy link
Collaborator

dej611 commented Mar 30, 2016

I think if you find the fix for this branch then it should be ok. Travis will pass and I'll happily merge.

@dej611
Copy link
Collaborator

dej611 commented Apr 6, 2016

Can you please merge the latest sprint and see if it passes?
The latest sprint passes all the rspec tests.

@dej611
Copy link
Collaborator

dej611 commented Apr 10, 2016

I believe that phantomjs error is due to some issues outside of our control, but perhaps there's a workaround.
From some research I found that Travis-CI has phantom version 1.9.8 installed already - waiting to migrate to 2.0 - so if you're asking another version (as it does by default => 1.9.7) it will poke the BitBucket CDN which may have some issues.
In particular there are 2 issues with the CDN: version 1.9.7 doesn't exist there so a 403 message is downloaded and that stops the process, and sometimes the CDN will simply drop the calls because of anti-DDOS protection.

The solutions are two:

I vote for the former.

@hab278
Copy link
Collaborator Author

hab278 commented Apr 11, 2016

@dej611 I agree with you, I think that's the best immediate option.

@dej611
Copy link
Collaborator

dej611 commented Apr 13, 2016

Great.

@dej611 dej611 merged commit 6accc74 into linguisticexplorer:sprint Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants