Add a minimum completeness threshold when evaluating partition status #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluating partitions that lack complete offset data can lead to false positives. One particular case we saw that if there is only 1 offset for the partition, it will get incorrectly marked as stopped. There are other conceivable cases where you're going to get a bad evaluation until you have a baseline amount of data to work with. In order to deal with this, we can add a minimum threshold for completeness for evaluating partitions: any partition which has a completeness below this value will be marked as OK without evaluating it.
In order to make sure that you have at least 2 out of 10 offsets stored, you can set the minimum-completeness value to 0.20. The default value will be 0.0 (which is the current behavior). The configuration is set on the caching evaluator, so it goes under the config heading for that. You would need to define a config section like the following: