Tweak mermaid dataflow arrow heuristics for downstream pipelines #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tweaked the heuristics used for rendering the dataflow arrows in mermaid diagrams via the
!mermaid
command.Details
Previously, any downstream resources were fully connected to an upstream resource, even when downstream resources were themselves connected in series.
With this change, downstream resources are only connected to the upstream resource if they aren't already connected to something upstream.
As this is a heuristic, it's likely to break for some topologies, but it seems to work for existing use-cases. Keep in mind that this is only for visually inspecting pipelines -- the arrows are non-functional.
Testing
This was tested with an internal (non-public) adapter, with results along these lines: