-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for jamba model with Liger Kernel #214
base: main
Are you sure you want to change the base?
Conversation
CI is failing, we probably need to set |
There are fixes done on both repo, but never gets merged in or released:
My current solution is to comment out the tests until the above issues are fixed. However, I have run the convergence test locally. Any other suggestion is highly welcomed. |
@@ -27,6 +27,11 @@ dev = [ | |||
"seaborn", | |||
] | |||
|
|||
test = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not good. these two dependencies seem very heavy. is there an alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these won't be installed by default though. only when you pip install . '[test]'
they are installed.
they are not heavy actually. installation takes about 15 seconds
Summary
Add support for jamba model with Liger Kernel. The following ops can be patched with Liger kernel:
Testing Done
make test
to ensure correctnessmake checkstyle
to ensure code stylemake test-convergence
to ensure convergence