Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements
softcap
in the fused linear jsd, so it can be used forgemma2
modelsDetails
Assumes same softcap for teacher and student model
Testing Done
added tests for softcapping in
test_fused_linear_jsd.py
Hardware Type: L40S
run
make test
to ensure correctnessrun
make checkstyle
to ensure code stylerun
make test-convergence
to ensure convergence