Grpo loss #553
Open
Grpo loss #553
+649
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbeeching
reviewed
Feb 4, 2025
edbeeching
reviewed
Feb 4, 2025
test/chunked_loss/test_grpo_loss.py
Outdated
| attention_mask.view(-1)[mask_indices] = 0 | ||
|
|
||
| # Create rewards with shape [B, num_generations] | ||
| rewards = torch.randn(B * num_generations, device=device, dtype=dtype) |
There was a problem hiding this comment.
If it is not too much work, would it be possible to test a scenario where the rewards are same same, i.e all 1s?
RichhLi
approved these changes
Feb 18, 2025
|
so there was a small change to the loss: huggingface/trl#2881 which i will integrate here too |
lancerts
reviewed
Feb 18, 2025
shivam15s
reviewed
Feb 19, 2025
lancerts
reviewed
Feb 19, 2025
6 tasks
lancerts
approved these changes
Feb 19, 2025
|
Nice work!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the GRPO chunked loss
fixes issue #548
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence