Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use MetadataAuditStamp instead of com.linkedin.common.AuditStamp #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsdonn
Copy link
Contributor

@jsdonn jsdonn commented Oct 31, 2023

Saw some downstream errors complaining about namespace mismatch i.e.

com.linkedin.schemaregistry.validation.IncompatibleSchemaException: com.linkedin.schemaregistry.AvroSchemaRenameException: (suspected) attempt to rename nested RECORD com.linkedin.common.AuditStamp to com.linkedin.pegasus2avro.common.AuditStamp
At :MetadataAuditEvent:auditStamp:union

The reason is because the downstream (metadata-models) explicitly excludes core-models module, which com.linkedin.common.AuditStamp is a part of. So one solution to this is to define our own AuditStamp model and use that instead. To avoid confusion, renamed to MetadataAuditStamp.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant