Correctly handle deletion of cache entry #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See documentation in code for more details, but the high-level problem is that an entry was deleted too early from the cache, orphaning the notification loop. If the same resource gets re-created, it would create a new entry and execute a new notification loop. These two loops would then deliver competing notifiations to subscribers.
bohhyang
approved these changes
Mar 21, 2025
| // Because the notification loop may still be running from the previous call to Set, the value may be | ||
| // still be present in the cache for a short while. However, it is expected to *eventually* | ||
| // disappear. | ||
| require.Eventually(t, func() bool { return !inCache(c) }, time.Second, time.Millisecond) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See documentation in code for more details, but the high-level problem is that an entry was deleted too early from the cache, orphaning the notification loop. If the same resource gets re-created, it would create a new entry and execute a new notification loop. These two loops would then deliver competing notifiations to subscribers.