Add an option to only use brokers that are present in Zookeeper #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use the
removeaction in the tools to transfer partitions off a dead broker, the partitions get assigned to all brokers incluster.brokersif-tis not specified.However, if some of our topics is in a bad state (ie. some of the brokers in the ISR are dead), those dead brokers also get added to
cluster.brokersand the partitions can potentially be assigned to them in the tool. This will cause the reassignment to fail.I would like to propose adding a flag that controls which brokers are added to the
clusterin the initial setup, and use the Zookeeper broker config as the source of truth. I don't have context on why we would want to add potentially dead brokers, but this allows us to keep both scenarios.