Avoid handling StopReplicaRequest if no replicas to stop #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCisGG
deleted the
20230815_remove_stop_replica_requests_if_no_partitions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LI_DESCRIPTION = LIKAFKA-54083
EXIT_CRITERIA = N/A
Description
This is a bug found when investigating LIKAFKA-54083. Basically a StopReplicaRequest is built from LiCombinedControlRequest no matter whether there are actually replicas to stop or not. That's why we see a log line here upon handling each single LiCombinedControlRequest:
2023/08/01 13:17:47.789 [logger] [Broker id=83691] Handling StopReplica request correlationId 25251 from controller 78691 for 0 partitionsWe should avoid building and handling such request when there are no replicas to stop. It will not only clean up the logs, but also slightly improve the performance of handling LiCombinedControlRequest.