Add QuotaV2Handler into produce path #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgarvey
force-pushed
the
quotav2handler
branch
2 times, most recently
from
700b20e
to
25919ee
Compare
nickgarvey
changed the title
CCisGG
approved these changes
Jan 23, 2024
nickgarvey
force-pushed
the
quotav2handler
branch
from
25919ee
to
137012b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add QuotaV2Handler to the produce path.
TICKET = LIKAFKA-54492
LI_DESCRIPTION =
Only the produce path is modified as quota v2 targets data volume, not request volume.
QuotaV2Handler is an interface with specific implementations set through config values. If no config is set, or the config is valid, then NoOpQuotaV2Handler is used. This approves all requests.
Adds unit tests to verify the NoOp handler is created by default, and the calls in the produce method work as expected.
EXIT_CRITERIA = None, this will carry forward indefinitely.
Committer Checklist (excluded from commit message)