Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LI-CHERRY-PICK] MINOR: example.com moved (#15758) #512

Merged
merged 1 commit into from
May 7, 2024
Merged

[LI-CHERRY-PICK] MINOR: example.com moved (#15758) #512

merged 1 commit into from
May 7, 2024

Conversation

hshi2022
Copy link

@hshi2022 hshi2022 commented May 7, 2024 •
edited
Loading

Reviewers: Chia-Ping Tsai [email protected], Kuan-Po (Cooper) Tseng [email protected], Viktor Somogyi-Vass [email protected]

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@akatona84 @hshi2022
MINOR: example.com moved (apache#15758)
b2a9437 
Reviewers: Chia-Ping Tsai <[email protected]>, Kuan-Po (Cooper) Tseng <[email protected]>, Viktor Somogyi-Vass <[email protected]>
@hshi2022 hshi2022 requested review from CCisGG and groelofs May 7, 2024 05:26
CCisGG
CCisGG approved these changes May 7, 2024
View reviewed changes
Copy link

@CCisGG CCisGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some descriptions on how that failed the tests and how this should fix the test failures?

@hshi2022 hshi2022 merged commit 1064c25 into 3.0-li May 7, 2024
25 checks passed
@hshi2022 hshi2022 deleted the fix_example_20240506 branch May 7, 2024 18:16
Yellow-Rice pushed a commit that referenced this pull request Jul 17, 2024
@hshi2022 @akatona84
[LI-CHERRY-PICK] MINOR: example.com moved (apache#15758) (#512)
e44f867 
Reviewers: Chia-Ping Tsai <[email protected]>, Kuan-Po (Cooper) Tseng <[email protected]>, Viktor Somogyi-Vass <[email protected]>

Co-authored-by: Andras Katona <[email protected]>
Yellow-Rice added a commit that referenced this pull request Jul 17, 2024
@Yellow-Rice @hshi2022 @akatona84
[LI-CHERRY-PICK] MINOR: example.com moved (apache#15758) (#512) (#516)
2720a23 
Reviewers: Chia-Ping Tsai <[email protected]>, Kuan-Po (Cooper) Tseng <[email protected]>, Viktor Somogyi-Vass <[email protected]>

Co-authored-by: Huilin Shi <[email protected]>
Co-authored-by: Andras Katona <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CCisGG CCisGG CCisGG approved these changes

@groelofs groelofs Awaiting requested review from groelofs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hshi2022 @CCisGG @akatona84