Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LI-CHERRY-PICK] MINOR: example.com moved (#15758) (#512) #516

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[LI-CHERRY-PICK] MINOR: example.com moved (#15758) (#512) #516

merged 1 commit into from
Jul 17, 2024

Conversation

Yellow-Rice
Copy link

@Yellow-Rice Yellow-Rice commented Jul 17, 2024 •
edited
Loading

Summary

  • In the ClientUtilsTest class, unit test testParseAndValidateAddressesWithReverseLookup has hardcoded IP addresses of example.com. The IP address has been changed and this PR is to cherry pick the commit that updates the hardcoded IP addresses.
  • This PR also include conflicts fixing. The original PR from upstream and the 3.0-li branch were based on a newer implementation of the ClientUtilsTest.

Tests

Executed impacted unit tests and it was successful.

./gradlew -Dorg.gradle.java.home=/Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/Home clients:test --tests org.apache.kafka.clients.ClientUtilsTest

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@hshi2022 @akatona84
[LI-CHERRY-PICK] MINOR: example.com moved (apache#15758) (#512)
e44f867 
Reviewers: Chia-Ping Tsai <[email protected]>, Kuan-Po (Cooper) Tseng <[email protected]>, Viktor Somogyi-Vass <[email protected]>

Co-authored-by: Andras Katona <[email protected]>
@Yellow-Rice Yellow-Rice merged commit 2720a23 into 2.4-li Jul 17, 2024
21 checks passed
@Yellow-Rice Yellow-Rice deleted the fix_ClientUtilsTest branch July 17, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitlw gitlw gitlw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yellow-Rice @gitlw @hshi2022