Refactor persistence strategy for dlo generation #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumedhsakdeo
reviewed
Mar 5, 2025
...ark/src/main/java/com/linkedin/openhouse/jobs/spark/DataLayoutStrategyGeneratorSparkApp.java
Outdated
Show resolved
Hide resolved
sumedhsakdeo
reviewed
Mar 5, 2025
...out/src/main/java/com/linkedin/openhouse/datalayout/persistence/StrategiesDaoTableProps.java
Outdated
Show resolved
Hide resolved
sumedhsakdeo
reviewed
Mar 5, 2025
libs/datalayout/src/main/java/com/linkedin/openhouse/datalayout/persistence/StrategiesDao.java
Outdated
Show resolved
Hide resolved
sumedhsakdeo
requested changes
Mar 5, 2025
sumedhsakdeo
previously approved these changes
Mar 10, 2025
...ark/src/main/java/com/linkedin/openhouse/jobs/spark/DataLayoutStrategyGeneratorSparkApp.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/linkedin/openhouse/jobs/spark/DataLayoutStrategyGeneratorSparkAppTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/linkedin/openhouse/jobs/spark/DataLayoutStrategyGeneratorSparkAppTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/linkedin/openhouse/jobs/spark/DataLayoutStrategyGeneratorSparkAppTest.java
Show resolved
Hide resolved
sumedhsakdeo
approved these changes
Mar 10, 2025
teamurko
approved these changes
Mar 10, 2025
teamurko
reviewed
Mar 10, 2025
| log.info( | ||
| "Generated {} strategies {}", | ||
| strategies.size(), | ||
| strategies.stream().map(Object::toString).collect(Collectors.joining(", "))); |
There was a problem hiding this comment.
can you preserve this logging line, it's helpful to see the values for an app run
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Made following changes:
isPartitionedto thedlo_strategiestable.appendToDloStrategiesTableso that the persistence strategy can be overridden.Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
Added E2E test for DLO generation app logic.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.