Cbrentharris/undo refaactor of anonymous class to lambda #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging main branch
When refactoring from an Anonymous class to a lambda, an infinite recursion occured because each analysis was required to then fork and create a new analysis when it was done because it defined a new anonymous class. This PR simply defines the class specifically to avoid it analyzing itself. A follow up should be to filter anonymous classes unrelated to parseq
zackthehuman
approved these changes
Oct 17, 2023
cbrentharris
added a commit
to cbrentharris/parseq
that referenced
this pull request
Oct 17, 2023
Create defined class to perform analysis within thread (linkedin#338)
cbrentharris
added a commit
to cbrentharris/parseq
that referenced
this pull request
Oct 17, 2023
Create defined class to perform analysis within thread (linkedin#338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create defined class to perform analysis within thread
When refactoring from an Anonymous class to a lambda, an infinite
recursion occured because each analysis was required to then
fork and create a new analysis when it was done because it defined
a new anonymous class.
This PR simply defines the class specifically to avoid it analyzing
itself. A follow up should be to filter anonymous classes unrelated
to parseq
Testing done -- brought it into local repository that was seeing stackoverflow
and no longer see it.