Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for ivy-publish and feature variants (capabilities) #568

Merged
merged 11 commits into from
May 24, 2021

Conversation

DPUkyle
Copy link
Member

@DPUkyle DPUkyle commented Mar 23, 2021

  • Additional test coverage for Ivy
  • Continue building with Gradle 5.2.1; requires reflection to access new API added in Gradle 5.3
  • New code block is a no-op unless the consuming project applies the ivy-publish plugin
  • Producing feature variants correctly using ivy-publish requires Gradle 6.1. Plugin will throw if ivy-publish is in use and Gradle version is below 6.1.

--

Depends on #566

There's a lot of info to unpack here; I'm preparing a talk to share with the maintainers. And of course I'll squash and rebase before merging.

@DPUkyle DPUkyle force-pushed the km/modern-ivy-publish branch 2 times, most recently from cd1a263 to 999aabc Compare March 23, 2021 16:36
@DPUkyle DPUkyle marked this pull request as ready for review March 23, 2021 17:29
@DPUkyle DPUkyle marked this pull request as draft April 2, 2021 04:15
@DPUkyle DPUkyle force-pushed the km/modern-ivy-publish branch 2 times, most recently from 04f1156 to 9325145 Compare April 2, 2021 05:39
@DPUkyle DPUkyle force-pushed the km/modern-ivy-publish branch 2 times, most recently from 351b87d to 3fca5c0 Compare May 5, 2021 19:28
@DPUkyle DPUkyle marked this pull request as ready for review May 5, 2021 19:39
@DPUkyle DPUkyle force-pushed the km/modern-ivy-publish branch 2 times, most recently from a659f5b to 1a9e581 Compare May 8, 2021 19:47
@DPUkyle DPUkyle force-pushed the km/modern-ivy-publish branch 2 times, most recently from 755e379 to 120c248 Compare May 21, 2021 22:49
@evanw555 evanw555 merged commit 87f9382 into linkedin:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants