-
Notifications
You must be signed in to change notification settings - Fork 92
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'linkedin:main' into rocksDBName
- Loading branch information
Showing
180 changed files
with
3,982 additions
and
1,360 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,10 @@ | ||
| version: 2 | ||
| registries: | ||
| # Helps find updates for non Maven Central dependencies' | ||
| duckdb-snapshots: | ||
| type: maven-repository | ||
| url: https://oss.sonatype.org/content/repositories/snapshots/ | ||
|
|
||
| updates: | ||
| - package-ecosystem: "gradle" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "daily" | ||
| registries: | ||
| - duckdb-snapshots | ||
| # Automatically update these dependencies | ||
| allow: | ||
| - dependency-name: "org.duckdb:duckdb_jdbc" | ||
| - dependency-name: "org.duckdb:duckdb_jdbc" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| name: Enforce Max Lines Changed Per File | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - '**/*.java' # Monitor changes to Java files | ||
| - '**/*.avsc' # Monitor changes to Avro schema files | ||
| - '**/*.proto' # Monitor changes to proto schema files | ||
|
|
||
| jobs: | ||
| enforce-lines-changed: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Fetch PR Title via GitHub API | ||
| id: pr_details | ||
| run: | | ||
| PR_NUMBER=${{ github.event.pull_request.number }} | ||
| PR_TITLE=$(curl -s -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \ | ||
| -H "Accept: application/vnd.github.v3+json" \ | ||
| "https://api.github.com/repos/${{ github.repository }}/pulls/$PR_NUMBER" | jq -r '.title') | ||
| echo "pr_title=$PR_TITLE" >> $GITHUB_ENV | ||
| PR_DESCRIPTION=$(curl -s -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \ -H "Accept: application/vnd.github.v3+json" \ | ||
| "https://api.github.com/repos/${{ github.repository }}/pulls/$PR_NUMBER" | jq -r '.body') | ||
| { | ||
| echo "pr_description<<EOF" | ||
| echo "$PR_DESCRIPTION" | ||
| echo "EOF" | ||
| } >> "$GITHUB_ENV" | ||
| - name: Check for Override Keyword | ||
| id: check_override | ||
| run: | | ||
| # Define the keyword for override | ||
| OVERRIDE_KEYWORD="DIFFSIZEOVERRIDE" | ||
| # Check PR title and body for the keyword | ||
| if printf "%s%s" "$pr_title$pr_description" | grep -iq "$OVERRIDE_KEYWORD"; then | ||
| echo "Override keyword found. Skipping validation." | ||
| echo "override=true" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "override=false" >> $GITHUB_OUTPUT | ||
| fi | ||
| - name: Calculate Lines Changed Per File | ||
| if: ${{ steps.check_override.outputs.override != 'true' }} | ||
| id: lines_changed_per_file | ||
| run: | | ||
| # Define the maximum allowed lines changed per file | ||
| MAX_LINES=500 | ||
| MAX_TOTAL_LINES_ADDED=2000 | ||
| TOTAL_LINED_ADDED=0 | ||
| # Get the diff of the PR and process each file | ||
| EXCEEDED=false | ||
| JAVA_FILE=false | ||
| SCHEMA_FILE=false | ||
| while IFS=$'\t' read -r added removed file; do | ||
| # Skip test files | ||
| if [[ "$file" != *src/main* ]]; then | ||
| echo "Skipping file: $file" | ||
| continue | ||
| fi | ||
| if [[ "$file" == *.java ]]; then | ||
| JAVA_FILE=true | ||
| else | ||
| SCHEMA_FILE=true | ||
| fi | ||
| # Calculate total lines changed for the file | ||
| TOTAL=$((added + removed)) | ||
| TOTAL_LINED_ADDED=$((TOTAL_LINED_ADDED + added)) | ||
| echo "File: $file, Lines Changed: $TOTAL" | ||
| # Fail if there are both schema and Java file changes | ||
| if [[ "JAVA_FILE" == true && "SCHEMA_FILE" == true ]]; then | ||
| echo "The PR has both schema and Java code changes, please make a separate PR for schema changes." | ||
| echo "For schema file changes, please update build.gradle to update 'versionOverrides' inside compileAvro task to use fixed protocol version" | ||
| exit 1 | ||
| fi | ||
| if [[ "$TOTAL" -gt "$MAX_LINES" && "$JAVA_FILE" == "true" ]]; then | ||
| echo "File $file exceeds the maximum allowed lines changed ($TOTAL > $MAX_LINES)" | ||
| EXCEEDED=true | ||
| fi | ||
| done < <(git diff --numstat origin/main | grep -E '\.(java|avsc|proto)$') | ||
| # Fail if total line added exceeds max limit | ||
| if [ "$TOTAL_LINED_ADDED" -gt "$MAX_TOTAL_LINES_ADDED" ]; then | ||
| echo "Total added lines of all files exceed the maximum allowed lines ($TOTAL_LINED_ADDED > $MAX_TOTAL_LINES_ADDED)." | ||
| exit 1 | ||
| fi | ||
| # Fail if total number of lines added exceeds max limit | ||
| if [ "$EXCEEDED" = true ]; then | ||
| echo "Above files exceed the maximum allowed lines changed ($MAX_LINES)." | ||
| exit 1 | ||
| fi | ||
| - name: Notify | ||
| if: failure() | ||
| run: | | ||
| echo "One or more files in the PR exceed the maximum allowed lines changed. Please review and adjust your changes to your files." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.