Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Add workflow for generating CI report in main branch #1284

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

majisourav99
Copy link
Contributor

Add workflow for generating CI report in main branch

We added CI report in forked branch PR workflow. This PR will be run after pushing to the main branch to generate test reports as workflow launched from forked PR does not have permission to do check runs.

How was this PR tested?

CI workflows

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

Copy link
Contributor

@nisargthakkar nisargthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow looks good. Left some comments to reduce some duplication

internal/venice-test-common/build.gradle Outdated Show resolved Hide resolved
.github/rawWorkflows/gh-ci-parameterized-flow-master.txt Outdated Show resolved Hide resolved
@nisargthakkar nisargthakkar changed the title Add workflow for generating CI report in main branch [build] Add workflow for generating CI report in main branch Nov 6, 2024
Copy link
Contributor

@nisargthakkar nisargthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one nit

internal/venice-test-common/build.gradle Outdated Show resolved Hide resolved
nisargthakkar
nisargthakkar previously approved these changes Nov 6, 2024
Copy link
Contributor

@nisargthakkar nisargthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants