[controller] use Utils::getRealTimeTopicName in tests
#1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjun4084346
force-pushed
the
rttopicname-part-2
branch
from
71e47bf to
f66bf8f
Compare
arjun4084346
commented
Nov 26, 2024
...enice-controller/src/main/java/com/linkedin/venice/controller/kafka/TopicCleanupService.java
Show resolved
Hide resolved
arjun4084346
force-pushed
the
rttopicname-part-2
branch
from
f66bf8f to
32eca34
Compare
arjun4084346
changed the title
arjun4084346
changed the title
arjun4084346
changed the title
Utils::getRealTimeTopicName in tests
arjun4084346
force-pushed
the
rttopicname-part-2
branch
from
32eca34 to
4d09147
Compare
arjun4084346
force-pushed
the
rttopicname-part-2
branch
2 times, most recently
from
fb19ffb to
4d56d04
Compare
arjun4084346
force-pushed
the
rttopicname-part-2
branch
from
4d56d04 to
e738b8d
Compare
arjun4084346
force-pushed
the
rttopicname-part-2
branch
from
e738b8d to
459caab
Compare
…code will also use Utils.getRealTimeTopicName Utils.getRealTimeTopicName returns the same value as Version.composeRealTimeTopic as of now, so we are able to make changes in any order
arjun4084346
force-pushed
the
rttopicname-part-2
branch
from
459caab to
82ef08a
Compare
sushantmane
reviewed
Dec 6, 2024
...ent/src/test/java/com/linkedin/davinci/kafka/consumer/KafkaConsumerServiceDelegatorTest.java
Outdated
Show resolved
Hide resolved
...a-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTaskTest.java
Show resolved
Hide resolved
...a-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTaskTest.java
Show resolved
Hide resolved
...a-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTaskTest.java
Outdated
Show resolved
Hide resolved
...inci-client/src/test/java/com/linkedin/davinci/kafka/consumer/TopicExistenceCheckerTest.java
Outdated
Show resolved
Hide resolved
sushantmane
reviewed
Dec 6, 2024
...test-common/src/integrationTest/java/com/linkedin/venice/controller/TestIncrementalPush.java
Outdated
Show resolved
Hide resolved
sushantmane
reviewed
Dec 6, 2024
...grationTest/java/com/linkedin/venice/controller/TestParentControllerWithMultiDataCenter.java
Outdated
Show resolved
Hide resolved
...grationTest/java/com/linkedin/venice/controller/TestParentControllerWithMultiDataCenter.java
Outdated
Show resolved
Hide resolved
.../src/integrationTest/java/com/linkedin/venice/controller/TestTopicRequestOnHybridDelete.java
Outdated
Show resolved
Hide resolved
...ationTest/java/com/linkedin/venice/controller/TestVeniceHelixAdminWithSharedEnvironment.java
Show resolved
Hide resolved
...ationTest/java/com/linkedin/venice/controller/TestVeniceHelixAdminWithSharedEnvironment.java
Outdated
Show resolved
Hide resolved
.../src/integrationTest/java/com/linkedin/venice/controller/server/TestAdminSparkWithMocks.java
Outdated
Show resolved
Hide resolved
.../src/integrationTest/java/com/linkedin/venice/endToEnd/DaVinciLiveUpdateSuppressionTest.java
Outdated
Show resolved
Hide resolved
...nice-controller/src/test/java/com/linkedin/venice/controller/TestVeniceParentHelixAdmin.java
Outdated
Show resolved
Hide resolved
sushantmane
approved these changes
Dec 7, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change references for
Version::composeRealTimeTopictoUtils::getRealTimeTopicNameThis is the continuation work of #1345
Changing references for
Version::composeRealTimeTopictoUtils::getRealTimeTopicName. Because there are too many references to review easily, only references in test files are changed in this PR.Resolves #XXX
How was this PR tested?
Does this PR introduce any user-facing changes?