Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Test to validate fully compatiblity of RocksDB BlobDB integration #1424

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

gaojieliu
Copy link
Contributor

The test case validates the BlobDB in the following way:

  1. Disable BlobDB and insert a bunch of entries and make sure no blob files are generated.
  2. Enable BlobDB and insert more entries and validate there are some blob files are generated and validate all the entries added in 1&2.
  3. Disable BlobDB again and insert more entries and make sure the the total number of blob files doesn't change.
  4. Validate all the entries inserted in 1&2&3.

Summary, imperative, start upper case, don't end with a period

How was this PR tested?

CI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

The test case validates the BlobDB in the following way:
1. Disable BlobDB and insert a bunch of entries and make sure
   no blob files are generated.
2. Enable BlobDB and insert more entries and validate there are
   some blob files are generated and validate all the entries
   added in 1&2.
3. Disable BlobDB again and insert more entries and make sure the
   the total number of blob files doesn't change.
4. Validate all the entries inserted in 1&2&3.
Copy link
Contributor

@FelixGV FelixGV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gaojie!

@gaojieliu gaojieliu merged commit ca17096 into linkedin:main Jan 10, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants