[compat] [controller] add a field largestUsedRTVersionNumber in store config
#1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjun4084346
force-pushed
the
rtnamechange
branch
3 times, most recently
from
1e2c1f9 to
e74aa24
Compare
arjun4084346
changed the title
largestUsedRTVersionNumber in store config
arjun4084346
force-pushed
the
rtnamechange
branch
from
e74aa24 to
d34bb0c
Compare
arjun4084346
force-pushed
the
rtnamechange
branch
from
d34bb0c to
a910cab
Compare
arjun4084346
force-pushed
the
rtnamechange
branch
from
a910cab to
667dd27
Compare
sushantmane
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Thanks, @arjun4084346 . Please take a look at my comments and let me know if you have any questions.
internal/venice-common/src/main/java/com/linkedin/venice/meta/ZKStore.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/controllerapi/ControllerClient.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/helix/HelixStoreGraveyard.java
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/helix/HelixStoreGraveyard.java
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/helix/HelixStoreGraveyard.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/test/java/com/linkedin/venice/helix/HelixStoreGraveyardUnitTest.java
Show resolved
Hide resolved
...ionTest/java/com/linkedin/venice/helix/TestHybridStoreRepartitioningWithMultiDataCenter.java
Outdated
Show resolved
Hide resolved
...ionTest/java/com/linkedin/venice/helix/TestHybridStoreRepartitioningWithMultiDataCenter.java
Outdated
Show resolved
Hide resolved
services/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java
Outdated
Show resolved
Hide resolved
sushantmane
previously approved these changes
Feb 21, 2025
sushantmane
reviewed
Feb 21, 2025
arjun4084346
force-pushed
the
rtnamechange
branch
from
bd1860f to
0a74b4c
Compare
sushantmane
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a field largestUsedRTVersionNumber in store config, which will be used to create new RT topic name whenever needed in future work
When we delete and recreate a store, we do not want to use the same old real time topic name, because that might not have been fully cleaned up. We want to use a new name, and to create the new name, we need to know the previous name that was ever used. This config will help in finding this out.
Resolves #XXX
How was this PR tested?
Does this PR introduce any user-facing changes?