Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fetch tarpaulin binary instead of compiling #2532

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

olix0r
Copy link
Member

@olix0r olix0r commented Nov 17, 2023

This should shave 2+ minutes off of coverage tests.

This should shave 2+ minutes off of coverage tests.
@olix0r olix0r marked this pull request as ready for review November 17, 2023 20:58
@olix0r olix0r requested a review from a team as a code owner November 17, 2023 20:58
@olix0r olix0r enabled auto-merge (squash) November 17, 2023 20:58
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (9f7e7ac) 58.56% compared to head (9f267aa) 67.66%.
Report is 4 commits behind head on main.

Files Patch % Lines
linkerd/app/outbound/src/http/concrete.rs 50.00% 2 Missing ⚠️
linkerd/app/outbound/src/http/logical.rs 60.00% 2 Missing ⚠️
linkerd/app/outbound/src/http/logical/profile.rs 0.00% 2 Missing ⚠️
linkerd/app/outbound/src/http/logical/policy.rs 0.00% 1 Missing ⚠️
...kerd/app/outbound/src/http/logical/policy/route.rs 75.00% 1 Missing ⚠️
.../outbound/src/http/logical/policy/route/backend.rs 0.00% 1 Missing ⚠️
...erd/app/outbound/src/http/logical/policy/router.rs 0.00% 1 Missing ⚠️
linkerd/app/outbound/src/opaq.rs 50.00% 1 Missing ⚠️
linkerd/app/outbound/src/opaq/logical.rs 50.00% 1 Missing ⚠️
linkerd/stack/metrics/src/service.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2532      +/-   ##
==========================================
+ Coverage   58.56%   67.66%   +9.09%     
==========================================
  Files         327      341      +14     
  Lines       15423    16108     +685     
==========================================
+ Hits         9033    10899    +1866     
+ Misses       6390     5209    -1181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olix0r olix0r force-pushed the ver/coverage-fetch branch from 34d9f4d to 9f267aa Compare November 17, 2023 21:22
@olix0r olix0r merged commit 8da6421 into main Nov 17, 2023
11 checks passed
@olix0r olix0r deleted the ver/coverage-fetch branch November 17, 2023 21:33
olix0r added a commit to linkerd/linkerd2 that referenced this pull request Nov 30, 2023
* Add a .codecov.yml (linkerd/linkerd2-proxy#2527)
* stack: Add BoxCloneSyncService (linkerd/linkerd2-proxy#2523)
* ci: Compute coverage over all tests (linkerd/linkerd2-proxy#2528)
* stack-metrics: Implement Clone for TrackService (linkerd/linkerd2-proxy#2524)
* ci: Fetch tarpaulin binary instead of compiling (linkerd/linkerd2-proxy#2532)
* ci: Enable coverage on main and all PRs (linkerd/linkerd2-proxy#2533)
* test: Cleanup consecutive_failures_accrue (linkerd/linkerd2-proxy#2531)
* test: Improve error reporting in gauges_endpoints (linkerd/linkerd2-proxy#2530)
* test: Cleanup outbound_balancer_waits_for_ready_endpoint (linkerd/linkerd2-proxy#2529)
* meshtls: Consolidate TLS ID verification (linkerd/linkerd2-proxy#2534)
* build(deps): bump DavidAnson/markdownlint-cli2-action (linkerd/linkerd2-proxy#2537)
* build(deps): bump tj-actions/changed-files from 40.1.1 to 40.2.0 (linkerd/linkerd2-proxy#2536)

Signed-off-by: Oliver Gould <[email protected]>
olix0r added a commit to linkerd/linkerd2 that referenced this pull request Nov 30, 2023
* Add a .codecov.yml (linkerd/linkerd2-proxy#2527)
* stack: Add BoxCloneSyncService (linkerd/linkerd2-proxy#2523)
* ci: Compute coverage over all tests (linkerd/linkerd2-proxy#2528)
* stack-metrics: Implement Clone for TrackService (linkerd/linkerd2-proxy#2524)
* ci: Fetch tarpaulin binary instead of compiling (linkerd/linkerd2-proxy#2532)
* ci: Enable coverage on main and all PRs (linkerd/linkerd2-proxy#2533)
* test: Cleanup consecutive_failures_accrue (linkerd/linkerd2-proxy#2531)
* test: Improve error reporting in gauges_endpoints (linkerd/linkerd2-proxy#2530)
* test: Cleanup outbound_balancer_waits_for_ready_endpoint (linkerd/linkerd2-proxy#2529)
* meshtls: Consolidate TLS ID verification (linkerd/linkerd2-proxy#2534)
* build(deps): bump DavidAnson/markdownlint-cli2-action (linkerd/linkerd2-proxy#2537)
* build(deps): bump tj-actions/changed-files from 40.1.1 to 40.2.0 (linkerd/linkerd2-proxy#2536)

Signed-off-by: Oliver Gould <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants