Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct semantic conventions for trace labels #3484

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

sfleen
Copy link
Collaborator

@sfleen sfleen commented Dec 20, 2024

The OpenTelemetry spec defines the semantic conventions that HTTP services should use for the labels included in traces: https://opentelemetry.io/docs/specs/semconv/http/http-spans/

Previously, we were using an outdated version of this spec for the OpenCensus traces. This updates the labels to match the current spec.

The notable changes updates to the path for HTTP method and status code, the fields that include the URL parts, and more rigorously following the standard for propagating the Host header.

@sfleen sfleen requested a review from a team as a code owner December 20, 2024 16:47
Copy link
Collaborator

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good! i have two really minor nits to offer, but the change itself seems great 🙂

linkerd/trace-context/src/service.rs Outdated Show resolved Hide resolved
linkerd/trace-context/src/service.rs Show resolved Hide resolved
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 66.78%. Comparing base (96124bc) to head (470a701).
Report is 688 commits behind head on main.

Files with missing lines Patch % Lines
linkerd/trace-context/src/service.rs 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3484      +/-   ##
==========================================
- Coverage   67.68%   66.78%   -0.90%     
==========================================
  Files         332      388      +56     
  Lines       15158    18155    +2997     
==========================================
+ Hits        10259    12125    +1866     
- Misses       4899     6030    +1131     
Files with missing lines Coverage Δ
linkerd/trace-context/src/service.rs 16.66% <0.00%> (-3.34%) ⬇️

... and 173 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 387197e...470a701. Read the comment docs.

The OpenTelemetry spec defines the semantic conventions that HTTP services should use for the labels included in traces: https://opentelemetry.io/docs/specs/semconv/http/http-spans/

Previously, we were using an outdated version of this spec for the OpenCensus traces. This updates the labels to match the current spec.

The notable changes updates to the path for HTTP method and status code, the fields that include the URL parts, and more rigorously following the standard for propagating the Host header.

Signed-off-by: Scott Fleener <[email protected]>
@sfleen sfleen enabled auto-merge (rebase) January 6, 2025 13:38
@sfleen sfleen merged commit 563dd3f into linkerd:main Jan 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants