Skip to content

Commit

Permalink
ci: Make errors fatal (#11630)
Browse files Browse the repository at this point in the history
We have `continue-on-error: true` marked on several integration
workflows. It appears that GitHub's behavior has changed to now mark
these tests as green even when they fail.

This change removes this setting from integration tests so errors are
reported properly. It also disables cni-calico-deep until #11617 is merged.
  • Loading branch information
olix0r authored Nov 17, 2023
1 parent 71cc411 commit 503a384
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@ jobs:
strategy:
matrix:
test:
- cni-calico-deep
# Pending https://github.com/linkerd/linkerd2/pull/11617
#- cni-calico-deep
- deep
continue-on-error: true
runs-on: ubuntu-20.04
timeout-minutes: 15
steps:
Expand Down Expand Up @@ -262,7 +262,6 @@ jobs:
- uninstall
- upgrade-edge
- upgrade-stable
continue-on-error: true
runs-on: ubuntu-20.04
timeout-minutes: 15
steps:
Expand Down Expand Up @@ -305,7 +304,6 @@ jobs:
test-viz:
needs: [tag, changed-viz, build-cli, build-core, build-ext]
if: needs.changed-viz.outputs.modified == 'true'
continue-on-error: true
runs-on: ubuntu-20.04
timeout-minutes: 15
steps:
Expand Down

0 comments on commit 503a384

Please sign in to comment.