feat(proto-config): Add http protocol configuration #13661
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfleen
force-pushed
the
protocol-detect-http1
branch
2 times, most recently
from
a24351b to
59a33b5
Compare
Currently, we store whether or not a port in a parent is opaque with a simple boolean. This works, but is somewhat restrictive if we want to specifiy different port protocols in the resource definition. This converts it to a proper `AppProtocol` enum, which will allow us to use different protocol specifications for ports in the future. Signed-off-by: Scott Fleener <[email protected]>
This allows specifying that a service port is opaque via `"linkerd.io/opaque"` in the `appProtocol` field. This also includes a fair amount of tests and test infrastructure for future `appProtocol` values. Signed-off-by: Scott Fleener <[email protected]>
This adds `"http"` and `"kubernetes.io/h2c"` as a valid values for service port `appProtocol`. Signed-off-by: Scott Fleener <[email protected]>
sfleen
force-pushed
the
protocol-detect-http1
branch
from
59a33b5 to
c8bbd55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds "http" and "kubernetes.io/h2c" as a valid values for service port appProtocol. Continuation of #13660.