Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial draft of the security audit blog post #1924

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Conversation

wmorgan
Copy link
Member

@wmorgan wmorgan commented Feb 14, 2025

No description provided.

Signed-off-by: William Morgan <[email protected]>
@wmorgan wmorgan requested review from travisbeckham and a team February 14, 2025 21:31
Copy link
Collaborator

@travisbeckham travisbeckham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good with one comment on the frontmatter.

Also, when creating blog posts, it's best if you run Hugo locally so all of the images will be generated and checked in to the repo.

@wmorgan
Copy link
Member Author

wmorgan commented Feb 16, 2025

Also, when creating blog posts, it's best if you run Hugo locally so all of the images will be generated and checked in to the repo.

@travisbeckham To confirm, I should check in the resources/_gen/image directory?

@travisbeckham
Copy link
Collaborator

travisbeckham commented Feb 17, 2025

@travisbeckham To confirm, I should check in the resources/_gen/image directory?

@wmorgan Yes, this is correct. Here's a bit of background on why it works this way...

The resources/_gen/images directory is included in source control because this is where Hugo caches processed images. Each time Hugo is built, it resizes blog images to reasonable sizes, creates thumbnails, then saves them in this directory. If we don't include this directory in source control, Hugo would have to regenerate all of the blog images every time the site is published, resulting is slow build times.

The reason why I implemented this process is because we had blog post cover images that were several megabytes in size that were also being used as thumbnail images.

This process does create some irritation though...

Unfortunately, if we don't run hugo locally when creating a new blog post, the images will get created at build time and not be added to source control. This means the next PR where the images are generated locally will include them, which is not ideal. I also realized that this requirement is not documented in the readme, so if we keep this process, I will get make note of it.

To add another irritation to this, Hugo has now changed the naming structure of generated images a couple times. This means that we currently have to be all running version v0.131.0 - v0.141.0, otherwise we'll encounter a renaming mess.

If it is cumbersome having Hugo process the blog images, we can certainly reevaluate this. We'd just need to manually ensure all blog images are created within certain guidelines.

Signed-off-by: William Morgan <[email protected]>
@wmorgan
Copy link
Member Author

wmorgan commented Feb 17, 2025

Current plan is to publish this on Tuesday 2/18

Signed-off-by: William Morgan <[email protected]>
Signed-off-by: William Morgan <[email protected]>
@wmorgan wmorgan merged commit aa1adbd into main Feb 18, 2025
7 checks passed
@wmorgan wmorgan deleted the wm/security-audit branch February 18, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants