Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve documentation for copy directives #36

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Silvanoc
Copy link
Contributor

@Silvanoc Silvanoc commented Aug 2, 2024

As of now it is unclear how copy directives are supposed to work.

This PR makes a proposal to improve the documentation directly on the transformation model descriptions, but without changing the specification itself.

Reviewers are requested to confirm/correct the assumptions that brought me to the documented understanding. The mentioned and hereby documented assumptions have been portrayed in the implementation draft available in #35.

There are still many under-specified aspects to be addressed later on.

As of now it is unclear how copy directives are supposed to work.
This commit improves the description, although there are still many
under-specified aspects to be addressed later on.

Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
@Silvanoc Silvanoc force-pushed the improve-documentation-copy branch from 51ebcc6 to 0164002 Compare August 2, 2024 08:20
Update the transformer model python datamodel according the latest
changes in the model itself.

Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
@cmungall cmungall marked this pull request as ready for review August 7, 2024 00:32
@cmungall cmungall merged commit 54e761a into main Aug 7, 2024
5 checks passed
@cmungall cmungall deleted the improve-documentation-copy branch August 7, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants