Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up and re-enable tests #44

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Fix up and re-enable tests #44

merged 4 commits into from
Dec 13, 2024

Conversation

pkalita-lbl
Copy link
Contributor

Fixes #42

Summary

  • Fix the test currently failing in the main branch (tests/test_transformer/test_transformer_examples.py). I'm not terribly familiar with the MultiFileTransformer class being tested there. My brief look at it indicated that some of the example directories simply weren't set up to meet its assumption about file names (i.e. having transformer files named {something}-to-{other}). So I just removed the ones that didn't seem designed to work with MultiFileTransformer from the test. If there's a better solution, please let me know.
  • Add running tests back into the main.yaml workflow, along with some general cleanup of the workflow.
  • Check in poetry.lock again, which seemed to have gotten deleted recently.
  • Fix a few tests so they don't leave untracked files behind.

@pkalita-lbl pkalita-lbl marked this pull request as ready for review December 13, 2024 22:42
@pkalita-lbl pkalita-lbl merged commit 7868618 into main Dec 13, 2024
6 checks passed
@pkalita-lbl pkalita-lbl deleted the issue-42-fix-tests branch December 13, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests not running in build and test workflow
2 participants