Handle overrides on SlotDerivation
#45
Merged
+396
−357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
These changes add a bit of logic to
_derive_slotwhich is equivalent to what is in_derive_classwhen the derivation contains anoverridesattribute.The diff for
tests/test_schema_mapper/test_schema_mapper.pylooks messy because I converted it to a pytest style test. But mainly I was adding three new test functions:test_overrides_in_class_derivationtest_overrides_in_slot_derivationtest_overrides_errors_with_unknown_attribute