Skip to content
This repository has been archived by the owner on Sep 17, 2022. It is now read-only.

Update structure of src folder in template #30

Merged
merged 12 commits into from
Jun 30, 2022

Conversation

sujaypatil96
Copy link
Member

Update the structure of the folder structure in the src folder of this template repo. To see what the updated structure looks like, see issue #29.

Copy link
Contributor

@hrshdhgd hrshdhgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema dir needs to go within the my-datamodel dir. So essentially, the data model and schema dirs should be at the same level. See sssom-schema and the figure in #29.

@sujaypatil96 sujaypatil96 requested a review from hrshdhgd June 29, 2022 17:38
@sujaypatil96
Copy link
Member Author

@hrshdhgd: great, thank you for the review. Do let me know what you think about the latest changes.

Copy link
Contributor

@hrshdhgd hrshdhgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sujaypatil96 sujaypatil96 merged commit 5378738 into main Jun 30, 2022
@sujaypatil96 sujaypatil96 deleted the spatil/update-src-structure branch June 30, 2022 16:39
Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go ahead and merge

Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see it's already merged great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants