-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple implementation of SPARQL queries #1183
Conversation
Use OCaml 4.14.1 for rule check, for consistency with other checks
most recent version compativle with ocamlformat 0.19.0
In today's meeting I think we agreed that this can be merged, with the todos above split into a separate issue along with a reminder to avoid/revisit the dependency on LWT when LWT goes away/is subsumed by other capabilities of OCaml 5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this branch with two different Links applications which will have exercised various database interactions:
- Guide to Pharmacology DB (nontemporal)
- https://github.com/vcgalpin/links-covid-curation (temporal)
Everything typechecked and showed no errors under execution.
I have not reviewed the code. I can do more specific testing if requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
The code is straightforward and ready to be merged. I left some minor comments for places that could use some clarification.
Light is green, trap is clean. |
This is for discussion/testing fo rthe moment. Some problems to potentially resolve before merging:
rdf
and some other libraries are added as hard Links dependencies. It would be good to have a separate "driver" for the SPARQL querying interface, like for the databases.