Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better workaround for issue #1187 (warning 40 due to @@deriving sexp) #1188

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Better workaround for issue #1187 (warning 40 due to @@deriving sexp) #1188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52deb33
workaround
frank-emrich Oct 17, 2023
72d8590
open Sexplib0.Sexp_conv instead
frank-emrich Oct 18, 2023
7ab3429
require v0.16.0 or newer
frank-emrich Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lens/column.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
open Lens_utility
module Type = Phrase_type

(* Workaround for issue #1187 (i.e., the @@deriving sexp clause on t
below creates code triggering warning 40 otherwise) *)
open Sexplib0.Sexp_conv_record.Fields
open Sexplib0.Sexp_conv_record.Kind

type t = {
table : string;
name : string;
Expand Down
5 changes: 5 additions & 0 deletions lens/database.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ open Operators
open Lens_utility
module LPV = Phrase_value

(* Workaround for issue #1187 (i.e., the @@deriving sexp clause on t
below creates code triggering warning 40 otherwise) *)
open Sexplib0.Sexp_conv_record.Fields
open Sexplib0.Sexp_conv_record.Kind

type t = {
serialize : unit -> string;
driver_name : unit -> string;
Expand Down
5 changes: 5 additions & 0 deletions lens/sort.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ open Lens_utility
open Lens_utility.O
module Column = Column

(* Workaround for issue #1187 (i.e., the @@deriving sexp clause on t
below creates code triggering warning 40 otherwise) *)
open Sexplib0.Sexp_conv_record.Fields
open Sexplib0.Sexp_conv_record.Kind

type t = {
fds : Fun_dep.Set.t;
predicate : Phrase.t option;
Expand Down
5 changes: 5 additions & 0 deletions lens/value.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
open Lens_utility

(* Workaround for issue #1187 (i.e., the @@deriving sexp clause on t
below creates code triggering warning 40 otherwise) *)
open Sexplib0.Sexp_conv_record.Fields
open Sexplib0.Sexp_conv_record.Kind

type t =
| Lens of { table : Database.Table.t; sort : Sort.t }
| LensMem of { records : Phrase_value.t list; sort : Sort.t }
Expand Down
2 changes: 1 addition & 1 deletion links.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ depends: [
"result"
"ocamlfind"
"menhir" {>= "20210419"}
"ppx_sexp_conv" {<= "v0.15.1"}
"ppx_sexp_conv" {>= "v0.16.0"}
"calendar" {>= "2.0.4"}
"rdf_lwt" {>= "0.13.0"}
]
Loading