-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename links-mysql8 driver to links-mysql #1189
Conversation
This resolves #1182 |
Note that parts of the CI now state "Waiting for status to be reported". That's because I've renamed some of the CI steps, all tests are actually passing as intended. Once this PR lands I will perform the same renaming on which CI steps Github expects to have passed. |
Just delete the stale steps in the settings tab of this repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine generally, I have a couple of minor questions.
-
Looking at tests/database, there are currently two (identical) files
factorials.mysql8
andfactorials.mysql
, containing MySQL-specific SQL code to initialize the database for the testfactorials.links
. My guess is that after making this change, only thefactorials.mysql
file will ever be used by the test scripts, so thefactorials.mysql8
file can be deleted. -
Looking at the changes to tests/relational-lenses, I was initially surprised to see that
config.mysql8
is deleted and noconfig.mysql
is created. The reason seems to be thatconfig.mysql
exists and has the correct contents already, presumably because it was not deleted earlier. So that's fine. However, looking at the rest of this directory, it appears that there are again identical filesserial.mysql
andserial.mysql8
containing MySQL-specific database setup code where the second one will be dead code after this cange and so can be deleted now.
I mark "request changes" now because these bits of cleanup should probably happen now.
Thanks, those file were indeed meant to be deleted, good catch! |
@jamescheney If you don't object I will merge this tomorrow. |
Sorry, I didn't realize this was still waiting on me, LGTM. |
This PR renames the
links-mysql8
driver tolinks-mysql
.The idea is that for end users who upgrade from Links 0.9.7 to 0.9.8, the composition of #1178 (which removed the existing
links-mysql
driver) and this one has the effect of thelinks-mysql
driver changing from using themysql8
package under the hood in the future, with no further changes from users required.